Refactor: sorting provider domains into packages #664
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
burythehammer
commented
Aug 21, 2025
burythehammer
commented
- Provider domains like active-active and essentials have been sorted by packages
- Acceptance Tests remain in the provider package as they essentially test the provider not the packages
- Extracted out lots of common functionality to utils package
|
Great job! No new security vulnerabilities introduced in this pull request |
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - Updating and fixing documentation |
Collaborator
There was a problem hiding this comment.
I would like to see an entry noting that a refactor/movement of the Terraform code has taken place. This is more to mark a point in time if there was a future issue.
trentrosenbaum
requested changes
Aug 22, 2025
Collaborator
trentrosenbaum
left a comment
trentrosenbaum
left a comment
There was a problem hiding this comment.
I like the organisation of the resources and the tests. As long as the complete test suite passes then we can approve.
I would like the changelog to be updated to reflect this up to the code file structure.
…kages' into chore/sort-into-packages
Collaborator
Author
|
Given the huge amount of changes in this, I'm going to close this, as I think it will be better done piecemeal. Some of the work is already present in the PrivateLink changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.